Jack Cherng

Results 289 comments of Jack Cherng

> @jfcherng If no objections, we can merge this. Thoughts? let's go

Related to https://github.com/TerminalFi/LSP-copilot/pull/106

Hey @TerminalFi are you going to review https://github.com/TerminalFi/LSP-copilot/pull/178 ? I see you close this issue without merging that PR.

Hmm... I guess #178 won't help. The popup width is provided as an argument to a ST plugin API.

> It helps, I'll post example. I've tested this already. Oops, I thought it's because of https://github.com/TerminalFi/LSP-copilot/blob/fa70eafc1916737bf623480497ef34dcae61d1e1/plugin/ui/completion.py#L244

Will it work if we hard-code it like `max_width=9999` and limit it with CSS?

> @jfcherng we can either set higher defaults or create new settings > > ``` > > "completion_popup_max_height": "240", > "completion_popup_max_width": "640", > ``` Then yes, I think we have...

I have my changes. https://github.com/jfcherng/php-diff - Various bug fixes and performance rewrites. - Published on Composer. ([jfcherng/php-diff](https://packagist.org/packages/jfcherng/php-diff)) - UTF-8-ready. - Adapt semver 2. (i.e., version number = `major.minor.patch`) - Follow...

@JBlond I see you still develop php-diff recently. Maybe you would be interested in my repo above too.