ngx-markdown icon indicating copy to clipboard operation
ngx-markdown copied to clipboard

marked import instead of adding to scripts?

Open fxck opened this issue 4 years ago • 3 comments

I've been looking at this https://github.com/markedjs/marked/pull/1563 shouldn't it now be possible to simply import marked?

fxck avatar May 27 '20 06:05 fxck

HI @fxck,

Yes you're right, it should be possible to import marked now instead of including the whole bundle file.

jfcere avatar Jun 15 '20 14:06 jfcere

Any update on this topic? Was just scrolling by, while updating and saw that documentation still states to add bundle to scripts. Either I am missing something or this is closed, since things seem to work fine without it being in scripts list.

KIMBUM avatar Feb 09 '22 11:02 KIMBUM

Any update?

Rambou avatar Jul 13 '22 10:07 Rambou

As per ngx-markdown v17.0.0 the marked dependency is imported using ECMAScript Modules and won't trigger this warning anymore.

jfcere avatar Nov 17 '23 00:11 jfcere