run-elm icon indicating copy to clipboard operation
run-elm copied to clipboard

[WIP] Support elm 0.19

Open kachkaev opened this issue 6 years ago • 10 comments

This PR is a heads-up to my attempt to support Elm 0.19. The upgrade involves quite a lot of change from the way we execute node-elm-compiler to what we keep in fixtures.

Most of the tests pass, there are only one that needs some more work is path-to-elm. I'm temporary skipping it. Hope I'll find time to better document changes as well.

kachkaev avatar Sep 17 '18 00:09 kachkaev

All tests are now passing except those related to custom pathToElm. Opened https://github.com/rtfeldman/node-elm-compiler/issues/78 to see if we can find a solution upstream.

kachkaev avatar Sep 17 '18 21:09 kachkaev

Published @kachkaev/[email protected], which includes all changes up to the last commit. The failing test in travis is related to a jumping new line in one of the errors messages, which did not occur before. I'll fix this later.

We also need to enable Travis tests for PRs in this repo. The ones in my fork pass: https://travis-ci.com/kachkaev/run-elm/builds/85100237.

kachkaev avatar Sep 18 '18 07:09 kachkaev

@jfairbank if you have a second, could you please go to https://travis-ci.org/jfairbank/run-elm/settings and enable Build pushed pull requests like this?

screen shot 2018-09-18 at 08 13 01

kachkaev avatar Sep 18 '18 07:09 kachkaev

@kachkaev It's already enabled. GitHub services are deprecated, so I removed the Travis service and reinstalled it as a GitHub app. Maybe that will fix the problem? Try force pushing or something to trigger a build.

jfairbank avatar Sep 18 '18 12:09 jfairbank

Hmm it did not trigger...

kachkaev avatar Sep 18 '18 17:09 kachkaev

what can we do here?

brandly avatar Nov 05 '19 16:11 brandly

@brandly I got the fork working here a while ago:

  • https://www.npmjs.com/package/@kachkaev/run-elm
  • https://github.com/kachkaev/run-elm

Haven't looked at it for a while, so feel free to enhance it if needed.

kachkaev avatar Nov 05 '19 16:11 kachkaev

thanks for the quick reply! i'm interested in CLIs written in elm, and it looked like run-elm might be a good starting place. i might try to make sense of how elm-analyse does it, but i'll let you know if i end up using this. thanks again.

brandly avatar Nov 05 '19 19:11 brandly

Compilation failed
Compiling (1)-- TYPE MISMATCH ----------------------- src/RunElmMain157298357467829132220.elm

The 1st argument to `sendOutput` is not what I expect:

12|     ( (), sendOutput output )
                         ^^^^^^
This `output` value is a:

    List String -> String

But `sendOutput` needs the 1st argument to be:

    String

Detected problems in 1 module.

does the fork not support List String -> String? the docs still mention it.

brandly avatar Nov 05 '19 19:11 brandly

we have 0.19.1 meanwhile, any news here? run-elm is very useful for teaching purposes.

dimpase avatar Nov 06 '20 12:11 dimpase