jez500
Two fixes
Fixes the remote control pad from being 12 px above the main controls div in sass Fixes the now playing title from being cut off in browsers other than crhome in sass
You changed the files located in the dist folder but these are generated by grunt and compass. I don't really understand why they are checked into the repository anyway.
On the next build, these changes are going to be overridden. In order to make changes to the style.css file, you have to look for the corresponding files in src/theme/**/*.scss. All these files are processed and concatenated into the styles.css using compass.
I did both, I edited the sass and I checked in the built version. Sorry for checking in the built version, but I did make the changes to the source.
Hugh
On Thu, Jan 15, 2015 at 3:06 AM, Jan [email protected] wrote:
You changed the files located in the dist folder but these are generated by grunt and compass. I don't really understand why they are checked into the repository anyway.
On the next build, these changes are going to be overridden. In order to make changes to the style.css file, you have to look for the corresponding files in src/theme/*/.scss. All these files are processed and concatenated into the styles.css using compass.
— Reply to this email directly or view it on GitHub https://github.com/jez500/chorus/pull/94#issuecomment-70063965.
Nevermind, I'm sorry, didn't recognize you edited them, too. It's just a bit confusing to have all changes listed twice in the commits :)