bender
bender copied to clipboard
jez500
Add "target" option for URLs
Could you add an option to the define how the target URL gets opened? In Firefox I'm using an add-on called "Custom New Tab Page" and it has some issues when you try to open some links in an iframe instead of a new top frame.
This is also described in Homer's Github project.
Btw. I just migrated from Homer and I love the project. Keep up the good work!
Can you try 1.0.3 and see if it meets your needs? will use _blank as the target, not sure if that is enough
I don't think it worked. Still getting the following message:
Firefox Can’t Open This Page
To protect your security, example.local will not allow Firefox to display the page if another site has embedded it. To see this page, you need to open it in a new window.
For Homer I had to use _top.
Side note: I specifically pulled the image tagged "1.0.3" but in the logs I still got the following message:
Starting webserver
> [email protected] start
> nuxt start
Did you maybe miss to update the version here?
I think @TheSelox is correct with the _top suggestion. Also, I updated my instance to 1.0.3 and it seems to have completely reset my config file. Is this expected behavior?
I am using the Docker version of bender and did not experience any config issues related to the upgrade. I have since stopped the container, inserted ""newWindow": true," for all of my entries, and successfully restarted bender without any issues. All of the links now open in a tab as expected.
@nealhead, could you have accidentally overwritten your "config.json" file?
I suppose it's possible, but I am using the Docker from the Community app store in Unraid and just updated there.
@michealespinola turns out the Unraid container did not include the mount for /app/static to a persistent directory in the available settings so it resets every time the docker image is updated. This is fixed by manually adding the mount.
@nealhead glad to hear you figured it out! I'm newish to the docker container world and while I'm personally comfortable with it, I don't yet feel comfortable in subscribing advice. I wasn't sure how to question you about your config without seeming presumptuous.
I'm running docker on a Synology NAS and learned the hard-way early on about configuring volumes for saving persistent data. Nothing I had previously read really drove home the concept until I encountered my first issues with updating containers. But learning the hard-way is a great teacher!