James Tomlinson
James Tomlinson
Raised in #652. > It would be nice to have a page talking about the decision to open source Pywr, how to contribute via GitHub (issues and PRs), and what...
Some interest in converting flow to level and/or velocity by a rating curve. This could be done with the interpolation parameters (might need some new ones). But it might also...
`np.asarray` wraps does not copy data. `np.array` does. Let's be clear about making a copy of user data and try to use `np.array` in most places. Internally we can use...
https://github.com/pywr/pywr/blob/b2cc21a7a237e1ca17f40ba510abddbd29deada0/pywr/parameters/_control_curves.pyx#L221 should be: ``` self._values = np.array(values, dtype=np.float64) ```
Apparently this varies sufficiently in some places that it should be configurable.
From #660 > I'm wondering if accepting both `"type": "constant"` and `"type": "constantparameter"` is actually a bad code smell and we should require it one way or the other. Perhaps...
The current implementation uses a fixed double for efficiency. It would be nice if this could be a parameter so that empirical (or theoretical) pump efficiency equations can be modelled.
This might be style thing, but the `_parameters.pyx` file is very long. It might be better to have one pyx for each parameter and its associated schema. They could be...
It would be good to have certain components be defined as dependent on all other components or have all other components dependent on it. This is useful in situations where...