Jetty 12 - EXPERIMENT - Issue #8474 - return null on resolve() if resource doesn't exist

[joakime]

[joakime]

@sbordet here's the minimal change to have PathResource.resolve() behave the same as ResourceCollection.resolve().

[joakime]

Thank you for the preliminary review.

For now, hold off on any further reviews until I can move some of the oddball changes out of this PR into separate PRs (as once those are merged, it will cause a rebase in this PR to clean out those changes)

[joakime]

The removal of exist() has not been done on this PR.

[gregw]

Thank you for the preliminary review.

For now, hold off on any further reviews until I can move some of the oddball changes out of this PR into separate PRs (as once those are merged, it will cause a rebase in this PR to clean out those changes)

For anything like renaming of variables / fields etc. I think you can probably do them without a PR if they are not part of the public API. Just check with another developer and if they are OK, push directly to the branch.

[joakime]

From latest run https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-8597/10/tests

org.eclipse.jetty.tests.distribution.DemoModulesTests.testJspDump([1] ee8) Test Failure

java.lang.IllegalArgumentException: KeyStore Path does not exist: /home/jenkins/agent/workspace/jetty.project_PR-8597
  /tests/test-distribution/test-distribution-common/target/tests/test-bases/jetty_base_5828043306936187437/etc/test-keystore.p12

I wonder if this should be throwing, or not. I'm leaning towards throwing. (and fixing the testcase to actually have a keystore)

@sbordet and @lorban what do you think?

[joakime]

Closing this large (in commit count) PR in favor of #8702