jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Issue #6167 - Review failure cases of HttpOutput.Interceptor

Open lachlan-roberts opened this issue 4 years ago • 3 comments

Issue #6167

This PR adds extra testing around what happens if an HttpOutput.Interceptor throws or fails the callback.

Some changes were made to HttpOutput so that in most cases we will respond with a 500 response instead of just aborting the connection.

lachlan-roberts avatar Apr 30 '21 01:04 lachlan-roberts

Considering @lachlan-roberts research regarding this, I am switching this PR back to draft and Lachlan should work on a version that returns false from isReady if there is an exception that will be passed to onError.

@lachlan-roberts can you write up your findings either here on in the actual issue.

gregw avatar May 15 '21 22:05 gregw

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 09 '21 13:07 stale[bot]

This pull request has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 16 '22 00:09 github-actions[bot]

This pull request has been closed due to it having no activity.

github-actions[bot] avatar Oct 16 '22 00:10 github-actions[bot]