jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Issue #9511 Verify location of scanned class files

Open janbartel opened this issue 1 year ago • 3 comments

Closes #9511

Check that a class file that is about to be scanned is in the correct location, skipping it if not. For example, given a class with fully qualified name com.acme.Foo that comes from jar:file://someplace/somewhere.jar!/ ensure that class is located at jar:file://someplace/somewhere.jar!/com/acme/Foo.class.
This would skip the class if it was in eg jar:file://someplace/somewhere.jar!/this/is/the/wrong/place/com/acme/Foo.class. See the original issue #9400 for more examples.

janbartel avatar Oct 25 '23 05:10 janbartel

@janbartel make sure we also test for some.jar!/META-INF/versions/<ver>/com/acme/Foo.class.

sbordet avatar Oct 25 '23 07:10 sbordet

@sbordet there are already tests for that.

janbartel avatar Oct 25 '23 10:10 janbartel

AnnotatioParser doesn't look to be related to any eeX version. could it be in a single place?

Potentially we could move it into a core jetty-annotations module, but I think that would be a separate PR.

janbartel avatar Nov 01 '23 02:11 janbartel

@gregw shall we can this PR?

janbartel avatar Mar 01 '24 16:03 janbartel

@janbartel @gregw shall we close this PR as not useful?

joakime avatar Apr 11 '24 16:04 joakime

These changes aren't crucial.

janbartel avatar Apr 13 '24 07:04 janbartel