version-checker icon indicating copy to clipboard operation
version-checker copied to clipboard

added the option to use a AWS role ARN to authenticate to ECR if on EKS

Open htrappmann opened this issue 2 years ago • 2 comments

Added the option to use an AWS IAM role ARN to authenticate to ECR if on EKS as described here:
https://docs.aws.amazon.com/eks/latest/userguide/create-service-account-iam-policy-and-role.html
In this case you don't need to use fixed access-key/secret-key/session-token to authenticate to ECR.

Signed-off-by: Henryk Trappmann [email protected]

htrappmann avatar Aug 11 '21 09:08 htrappmann

Hi @htrappmann. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Aug 11 '21 09:08 jetstack-bot

/lgtm /approve

JoshVanL avatar Aug 22 '22 18:08 JoshVanL

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: htrappmann, JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Aug 22 '22 18:08 jetstack-bot