vault-unsealer icon indicating copy to clipboard operation
vault-unsealer copied to clipboard

Add new mode for vault-unsealer using ssm parameter with type SecureString

Open haad opened this issue 7 years ago • 8 comments

Add new mode aws-sec-ssm which is using ssm parameters type SecureString which can be automatically decrypted by AWS KMS key. Add example terraform templates which can be used to create KMS key and secureString paramaters.

haad avatar Oct 19 '18 09:10 haad

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: joshvanl

If they are not already assigned, you can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Oct 19 '18 09:10 jetstack-bot

/ok-to-test Hi @haad , thanks for the PR. Please can you sign off and add a release note

JoshVanL avatar Oct 25 '18 14:10 JoshVanL

@JoshVanL here you go.

haad avatar Oct 25 '18 15:10 haad

@haad Sorry, should have been more clear, it needs to be included in the root PR as described here https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md

and will look something like this https://github.com/jetstack/vault-unsealer/pull/24

There looks to also be some problems with go vet :)

JoshVanL avatar Oct 25 '18 16:10 JoshVanL

/assign @haad

JoshVanL avatar Nov 07 '18 15:11 JoshVanL

@JoshVanL This should do it :)

haad avatar Nov 07 '18 15:11 haad

@haad Thanks, I'll take a look when I get the chance :) /assign

JoshVanL avatar Nov 07 '18 17:11 JoshVanL

@haad: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Apr 09 '19 09:04 jetstack-bot