tarmak icon indicating copy to clipboard operation
tarmak copied to clipboard

Update kube-state-metrics to the latest version

Open MattiasGees opened this issue 6 years ago • 4 comments

Signed-off-by: Mattias Gees [email protected]

What this PR does / why we need it: This updates kube-state-metrics to the latest version and it fixes some RBAC issues we had with 1.4. With 1.4 we got errors in the logs

E0221 10:13:53.230160       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "configmaps" in API group "" at the cluster scope
E0221 10:13:54.238317       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "secrets" in API group "" at the cluster scope
E0221 10:13:54.239928       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "configmaps" in API group "" at the cluster scope
E0221 10:13:55.239963       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "secrets" in API group "" at the cluster scope
E0221 10:13:55.241302       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "configmaps" in API group "" at the cluster scope
E0221 10:13:56.241796       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "secrets" in API group "" at the cluster scope
E0221 10:13:56.242690       1 reflector.go:205] k8s.io/kube-state-metrics/pkg/collectors/collectors.go:91: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "configmaps" in API group "" at the cluster scope

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Update kube-state-metrics to 1.5.0

MattiasGees avatar Feb 21 '19 10:02 MattiasGees

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MattiasGees To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: simonswine

If they are not already assigned, you can assign the PR to them by writing /assign @simonswine in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Feb 21 '19 10:02 jetstack-bot

/unassign /assign @simonswine

MattiasGees avatar Feb 21 '19 11:02 MattiasGees

Can you have a look at this: https://twitter.com/opsgoodness/status/1098266699382620160

Don't want to get into that trouble with the update. The performance fixes seemed to have happened with 1.5.0

/assign @MattiasGees /unassign

simonswine avatar Feb 21 '19 13:02 simonswine

@MattiasGees: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-15-centos b3de0f06a44ca5ca45685a63e7cdd0b05cf55e79 link /test puppet-tarmak-acceptance-centos v1.15

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Jun 27 '19 10:06 jetstack-bot