tarmak icon indicating copy to clipboard operation
tarmak copied to clipboard

Use machine API types

Open JoshVanL opened this issue 6 years ago • 11 comments

What this PR does / why we need it: This PR implements the Machine API types taken from the Kubernetes Cluster API project. This introduces MachineDeployments and MachineSets as well as Machine, essentially renamed from Instances. Two new controllers are added to the API server that manage the behavior of Machine deployments and sets.

Every instance pool now has a corresponding deployment, and consequently a set, created to manage the machines in that pool.

This PR helps to implement ground work to further extend wing features such as puppet dry runs.

NOTE: wing-dev-mode must be run with this branch since wing and it's types have been heavily modified.

Change wing API types to use ones similar to Kubernetes Cluster API

JoshVanL avatar Dec 17 '18 15:12 JoshVanL

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: joshvanl

If they are not already assigned, you can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Dec 17 '18 15:12 jetstack-bot

Should be ready for a first round of reviews /assign @simonswine

JoshVanL avatar Dec 17 '18 15:12 JoshVanL

/test verify docs

JoshVanL avatar Dec 17 '18 15:12 JoshVanL

/test verify quick

JoshVanL avatar Dec 17 '18 15:12 JoshVanL

/test verify docs

JoshVanL avatar Dec 17 '18 16:12 JoshVanL

/test verify docs

JoshVanL avatar Dec 18 '18 09:12 JoshVanL

/test verify quick

JoshVanL avatar Jan 02 '19 10:01 JoshVanL

/unassign @simonswine /assign

JoshVanL avatar Jan 03 '19 14:01 JoshVanL

@JoshVanL: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 03 '19 14:01 jetstack-bot

/hold

I would not like to include this 0.6 release

simonswine avatar Jan 14 '19 09:01 simonswine

@JoshVanL: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-14-centos 8222615f3f4b8c788d9a71cc6499e2f3866771d4 link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Apr 11 '19 14:04 jetstack-bot