tarmak
tarmak copied to clipboard
jetstack
WIP: Recover properly when bastion goes down
What this PR does / why we need it: Allows the bastion to be created by reapplying when there it goes down
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #187
Allow bastion to be recreated by reapplying
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: dippynark
If they are not already assigned, you can assign the PR to them by writing /assign @dippynark in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@simonswine at the time this was written, the bastion would not be recreated from a reapply if it was deleted or was down for whatever reason - it also tries to speed up plan time when the bastion is down (so that the tarmak vault cluster resource and vault token resources don't hang for ages) but due to issues with terraform not rereading data resources at refresh time (https://github.com/hashicorp/terraform/issues/17034) this was not perfect
@dippynark: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@dippynark: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| tarmak-quick-verify | 7306c38cdd8417b5d8c6220cb1d09a6cdbdba05b | link | /test verify quick |
| tarmak-puppet-module-tarmak-acceptance-1-14-centos | 7306c38cdd8417b5d8c6220cb1d09a6cdbdba05b | link | /test puppet-tarmak-acceptance-centos v1.14 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.