tarmak
tarmak copied to clipboard
jetstack
Ensures results are of type *multierror.Error and call ErrorOrNil at return
What this PR does / why we need it: Due to a result being miss returned a bug was created. This PR ensures all append results are of *multierror.Error and return ErrorOrNil()
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: simonswine
If they are not already assigned, you can assign the PR to them by writing /assign @simonswine in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Not too sure why we need that?! This is exactly as usage suggest https://github.com/hashicorp/go-multierror
@JoshVanL: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@JoshVanL: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| tarmak-puppet-module-tarmak-acceptance-1-14-centos | 78a2add51e9490151e8ada4f9f57b404ecce6d0c | link | /test puppet-tarmak-acceptance-centos v1.14 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.