tarmak icon indicating copy to clipboard operation
tarmak copied to clipboard

Adds flag to use own AWS key pair

Open JoshVanL opened this issue 7 years ago • 7 comments

What this PR does / why we need it: Adds a flag to use an existing key pair in AWS.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #312

Release note:

NONE

JoshVanL avatar Jun 18 '18 20:06 JoshVanL

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: dippynark

Assign the PR to them by writing /assign @dippynark in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Jun 18 '18 20:06 jetstack-bot

/cc @dippynark

JoshVanL avatar Jun 20 '18 19:06 JoshVanL

/assign @dippynark

JoshVanL avatar Jun 27 '18 14:06 JoshVanL

/assign @simonswine

JoshVanL avatar Jul 09 '18 13:07 JoshVanL

I think this should be a configuration option in the tarmak.yaml for the aws provider (and should have the option to be overriden in AWS specific sections of environment,clusters or instancePools)

/unassign /assign @JoshVanL

simonswine avatar Jul 09 '18 14:07 simonswine

@JoshVanL: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jul 11 '18 07:07 jetstack-bot

@JoshVanL: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-14-centos 41657c3e90b7caa0442b53e9b2962ad148abf2ae link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Apr 11 '19 14:04 jetstack-bot