jetstack
WIP: Add script to update example manifests
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: We suggest the following additional approver: munnerz
Assign the PR to them by writing /assign @munnerz in a comment when ready.
The full list of commands accepted by this bot can be found here.
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment
This currently only updates the cassandra example. The elasticsearch example a bit more different from the manifest used in e2e tests, so I haven't added it yet.
/cc @munnerz
@kragniz: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| navigator-e2e-v1-7 | bbb0b72cd37a6d0e854df26ddcca594e332d031d | link | /test e2e v1.7 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
We also need a corresponding verify script here.
FWIW, as I've said before, I do not think our e2e tests should only be driven by docs. Instead, we should have tests for the things in our docs (i.e. using sphinx's testing features), but the e2e test suite should test more advanced features which may or may not make sense to include in our documentation.
@kragniz: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.