kube-oidc-proxy
kube-oidc-proxy copied to clipboard
Set usable and safe client-side rate limit on Kubernetes client
Hi!
First of all, thanks for this awesome project!
We started using kube-oidc-proxy
to access our clusters. Normally when a user uses the proxy to access a Kubernetes cluster, there isn't any problem, and works like a charm. However, when a machine/bot/app (e.g ArgoCD) starts using it the proxy starts rate-limiting the requests because the Kubernetes client client-side rate limit is not configured.
For example, our Argo CD installation failed constantly connecting to the clusters (get status, send actions...) because of this client-side rate limit.
This PR adds a safe default that it's known that works correctly:
- QPS:
100
- Burst:
100
Some projects that configure this to don't get this kind of problems:
Hi @slok. Thanks for your PR.
I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: slok
To complete the pull request process, please assign joshvanl after the PR has been reviewed.
You can assign the PR to them by writing /assign @joshvanl
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/assign @joshvanl
/release-note-none
:wave: Hi!
Could someone check this small PR, please :)
Many thanks!
:wave: Bump! :smile: