kube-oidc-proxy icon indicating copy to clipboard operation
kube-oidc-proxy copied to clipboard

OIDC auth request failure

Open redradrat opened this issue 3 years ago • 5 comments

I'm not sure whether it's actually ok to do so from a security perspective.

Not knowing why the initial OIDC auth call failed costs a lot of time though. This should be doable debug log mode maybe?

redradrat avatar Jan 19 '21 16:01 redradrat

@redradrat: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 19 '21 16:01 jetstack-bot

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • d0f97c2 add info as to why an OIDC request failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Jan 19 '21 16:01 jetstack-bot

Hi @redradrat. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 19 '21 16:01 jetstack-bot

concerns #185

redradrat avatar Jan 19 '21 16:01 redradrat

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Asteb612, redradrat To complete the pull request process, please assign joshvanl after the PR has been reviewed. You can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Feb 03 '22 21:02 jetstack-bot