kube-oidc-proxy icon indicating copy to clipboard operation
kube-oidc-proxy copied to clipboard

Published 20 hours ago • verified publisher icon jetstack

Add metrics

Open JoshVanL opened this issue 5 years ago • 3 comments

This PR metrics adds a number of metrics to the proxy.

The PR should be split up fairly well per commit.

It would be good to have a bit of insight into whether these metrics look sane... It is tricky not to make the number of time series explode here.

/assign @munnerz /assign @simonswine fixes #156

JoshVanL avatar Jun 18 '20 23:06 JoshVanL

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Jun 29 '20 16:06 jetstack-bot

Thanks for the review @james-w :) I've made the suggested changes or responded to you comments, and should be ready for another look /unassign /assign @james-w

JoshVanL avatar Jun 29 '20 16:06 JoshVanL

Pardon my ignorance, is this complete ? How do I get access to the metrics if it is? Thanks.

SimplySeth avatar Aug 26 '20 13:08 SimplySeth