devbox icon indicating copy to clipboard operation
devbox copied to clipboard

`python`'s `plugin_version` is overriden in lock with devbox 0.13.0

Open guillermoz-nutanix opened this issue 1 year ago • 3 comments

What happened?

After upgrading to 0.13.0, and running devbox shell (or devbox install in our CI), the devbox.lock was modified with this diff

diff --git a/devbox.lock b/devbox.lock
index 03cbb2524d..bd2020311e 100644
--- a/devbox.lock
+++ b/devbox.lock
@@ -524,7 +524,7 @@
     },
     "[email protected]": {
       "last_modified": "2024-03-08T13:51:52Z",
-      "plugin_version": "0.0.3",
+      "plugin_version": "0.0.4",
       "resolved": "github:NixOS/nixpkgs/a343533bccc62400e8a9560423486a3b6c11a23b#python312",
       "source": "devbox-search",
       "version": "3.12.2",

Steps to reproduce

  1. With devbox 0.12.0 install python
  2. Upgrade devbox to 0.13.0
  3. Run devbox install.

EDIT: I'm also able to repro the issue by running DEVBOX_USE_VERSION=0.12.0 devbox install, with versions 0.12.0 and 0.13.0. The plugin_version is set to 0.0.3 by 0.12.0 and 0.0.4 by 0.13.0.

Command

install, shell

devbox.json

{
  "packages": [
    "[email protected]",
    "[email protected]",
    "lsof@latest",
    "gh@latest",
    "xdg-utils@latest",
    "jq@latest",
    "[email protected]",
    "[email protected]",
    "[email protected]",
    "[email protected]"
  ],
  "shell": {
    "init_hook": [
      ". ./scripts/initialize.sh"
    ],
    "scripts": {
      "test": [
        "echo \"Error: no test specified\" && exit 1"
      ]
    }
  }
}

Devbox version

0.13.0

Nix version

2.18.1

What system does this bug occur on?

Linux (x86-64)

Debug logs

No response

guillermoz-nutanix avatar Sep 23 '24 17:09 guillermoz-nutanix

This is working as intended. The plugin was updated between 0.12.0 and '0.13.0`.

https://github.com/jetify-com/devbox/commit/6df893aad7550c191d876f6edb94df93a61d2adb#diff-b6b6fe9ddb1de4adddfb1ce9180cf19fb2a67cc72cfb38197e7abfca05fbf469R3

djgoku avatar Sep 25 '24 02:09 djgoku

@djgoku so it's intended if two people are using 2 different versions of devbox for them to constantly battle it out and for this file to change over and over again?

sstarcher avatar Oct 17 '24 17:10 sstarcher

@djgoku so it's intended if two people are using 2 different versions of devbox for them to constantly battle it out and for this file to change over and over again?

Likely not. But the plugins are tightly coupled to devbox versions.

At least that is my understanding.

djgoku avatar Oct 24 '24 02:10 djgoku