cdk-nextjs icon indicating copy to clipboard operation
cdk-nextjs copied to clipboard

Published 20 hours ago • verified publisher icon jetbridge

fix: Mark esbuild as an optional dep

Open revmischa opened this issue 3 years ago • 2 comments

Fixes #36

Not sure if this is the correct fix, people may need to manually install esbuild along with cdk-nextjs-standalone?

revmischa avatar Nov 25 '22 17:11 revmischa

This unfortunately does not work :(

khuezy avatar Dec 08 '22 22:12 khuezy

Can you try upgrade to v0.16.3 to see if that fixes the issue?

khuezy avatar Dec 08 '22 22:12 khuezy

If anyone knows how to fix this I'd love to hear it!

revmischa avatar Mar 21 '23 20:03 revmischa

Not needed anymore.

bestickley avatar Aug 03 '23 20:08 bestickley

@bestickley can you please elaborate why this is no longer needed? Its still listed as a requirement in the readme and my project won't build without a locked peer dependency on esbuild 0.17.16

https://github.com/jetbridge/cdk-nextjs/blob/80ae07b148b3c55f90ef559e1ce8abab612f5156/README.md?plain=1#L14

jadenv avatar Aug 17 '23 02:08 jadenv

@jadenv, I don't think making esbuild a peerDependency will work because this package is published as a construct which should be compatible with multiple programming languages. In non-JS programming languages you couldn't make esbuild a peer dependency. So I think esbuild will need to be bundled still. I think this is the case for all constructs on construct hub. Make sense?

bestickley avatar Aug 17 '23 10:08 bestickley