Jesse Wright
Jesse Wright
> Perhaps it's worth thinking of SourceArrayIterator as an orthogonal feature to UnionIterator and better addressed in a different PR if needed at all. So to conclude this PR is...
> Shall we extract `CircularList` to a separate file like `LinkedList`? That's probably sensible. When I was first writing I didn't have clarity on what APIs would need to be...
> Maybe OrderedSet extends LinkedList, adding O(1) has and delete operations via a Set or Map? I'll have a crack at this in the morning (jet lag is starting to...
> Could you details these a bit? See https://github.com/RubenVerborgh/AsyncIterator/pull/79#discussion_r934929002. The reason that test broke is because we do not subscribe to the error event of iterators until after we start...
> Can't we change that behavior? Just to make this even more concrete; if I have ```ts const source = range(1, Infinity).map(x => range(1, 10)) const unionRange = union(source) ```...
> Is there a reason we wouldn't want underscores to be recognized by this Regex? Underscores are not allowed at the start of a prefix according to the [turtle production...
Nice work! I like the approach and the opportunity for extension. My only reservation is whether the application of filters to a path will cause confusion for users - and...
> These changes also showed me that the preload handler is very minimal and only works in certain cases. Because we save the values and the filters inside the pathData...
@danielbeeke thankyou for your work - I'm happy with the state of the code in this PR but will wait for @RubenVerborgh to give the all clear as I know...