verify-pr-label-action icon indicating copy to clipboard operation
verify-pr-label-action copied to clipboard

Do not require valid labels if they are not specified

Open pmalek-sumo opened this issue 3 years ago • 3 comments

Hello,

Thanks for this awesome plugin!

I have a use case that involves only checking if a particular "invalid plugin" is set, let's say do not merge. I don't want to specify "positive labels" or in other words: I don't want to be forced to mark PRs as checked/ready to reviews/or else.

The only constraint I want this plugin to do is to add a "Request changes" review when do not merge label is added.

Can we somehow achieve this with current version of this PR or maybe it would require some changes to its core logic?

Here's the comment that this plugin outputs (ref)

This pull request does not contain a valid label. Please add one of the following labels: ['']

When the following config is used:

name: PRs Labels

on:
  pull_request_target:
    types: [opened, labeled, unlabeled, synchronize]

jobs:
  label:
    runs-on: ubuntu-latest
    steps:
      - uses: jesusvasquez333/[email protected]
        with:
          github-token: '${{ secrets.GITHUB_TOKEN }}'
          invalid-labels: 'do not merge'
          pull-request-number: '${{ github.event.pull_request.number }}'

pmalek-sumo avatar Jun 15 '21 11:06 pmalek-sumo

yeah i also need the something similar to this

kirankalathoti avatar Jul 26 '21 08:07 kirankalathoti

Seems to me that "invalid labels" is what you're looking for?

image

mateobelanger avatar Aug 06 '21 22:08 mateobelanger

This would be fine for me too.

caiogranero avatar Aug 03 '22 19:08 caiogranero