jesus2099
mb. ALL LINKS for other MB entities
It would be great to have search links for e.g. Release to RYM, AllMusic, Discogs, etc. and similar for Works (to that classical work site, Second Hand Songs, SACEM, …), Places (WP at least, possibly GeoNames or other location dbs), etc.
This for the ticket @Freso, I thought it existed but no. My plan is that appropriate links appear where they should. So it sounds like this, doesn’t is? If your auto link contains a parameter that can be matched on current page, it will display.
We used to have release auto links (#45) but this feature is even more general.
There is a bit of work in progress at y-van-z/konami-command/all-shook-up-links/mb_ALL-LINKS.user.js. Hidden links, edit buttons and Wikipedia links are already shown for all entities since y-van-z/konami-command@79d79eb16169768002b72754df1a2734165d204c. Next step is to show search links for all entities, that would address this issue.
Super, @y-van-z, thanks very much!
For artists, we have those parameters:
// %artist-id% (MBID)
// %arist-name%
// %artist-sort-name%
// %artist-family-name-first%
I don’t know what you plan to provide for other entities (you can provide nothing or minimal for a start, we can add later) but for releases, we used to have only those parameters:
%release-barcode%
%release-cataloguenumber%
%release-cataloguenumber-part1%
%release-cataloguenumber-part2%
I don’t know how better named could be the last 2. :)
The principle is that when ALL LINKS run, it will compute take all and only those autolinks that use a parameter starting with %currentEntytyType- (beware of %release- in %release-group-).
But I will take care of supporting those if you just start by enabling ALL LINKS (hidden links) on entities. You’re great. :+1:
I don’t know what you plan
I don't know either! It really depends on implementation glitches ahead. Name will be provided for sure and it will be easy to support any other parameter by simply adding it to a key/value object later on. But there is more to come in the next batch of commits. I will open a pull request once it solves this issue.
FYI @y-van-z I have just pushed a very small fix to ALL LINKS in master branch (version 2016.6.6).
I guess @y-van-z you are waiting to challenge the stability of your changes but once you feel it is ok I would very welcome a PR as your commit descriptions already sound seductive (and before mixing too many topics together as well). :thumb up: :)
Sorry for the long awaiting time, I swear I did not try to implement a coffee machine! :coffee: :wink: This pull request has no conflict with your fix bc113a9b59837e686e9ab5547c948becf00cb17a
Thanks, it’s superb. I have commented over there (#238) on the requirement to keep the entity type in the token names. Hey is coffee machine an expression to tell something overly complex that cannot be maintained or understood any more? We use the very funny French term usine à gaz (gasworks factory, cf. animated gif) for which I never found English equivalent.
Not at all, it is just a very nice extra feature which is usually not listed in the original specifications. Yet there are real implementation examples: video demonstration, see the :+1: of the thirsty man.
An English equivalent to usine à gaz seems to be white elephant for the unmaintainable aspect, and either Rube Goldberg machine (in the US) or Heath Robinson machine (in the UK) for the overly complex aspect, after the name of cartoonists.
PR #238 fixed this but @y-van-z has another ongoing all-shook-up branch that will implement all @Freso examples then we will close this ticket.
For SACEM link, it’s now https://sigried.sacem.fr/oeuvres/oeuvre/printOeuvre.do?cocv=7300202211 (cf. #263).
Thanks a lot to you @jesus2099 for your hard work at reviewing, updating and integrating this branch!