refactor(jest-snapshot): refactor Prettier related part
Summary
I noticed logic for Prettier 2 and 3 are not living together and seems there are differences (not touched in this PR).
Test plan
Deploy Preview for jestjs failed.
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 807cb3cb0c487c3c0b567396682b953e13cc9476 |
| Latest deploy log | https://app.netlify.com/sites/jestjs/deploys/67e2bfc68380240008e99837 |
Again, performance should be taken into account, synckit has better performance, TypeScript and native PnP support, etc.
For benchmark, see https://github.com/un-ts/synckit#benchmark
Sometimes even better: https://github.com/un-ts/synckit/actions/runs/14015583415/job/39240872165#step:7:1
Again, performance should be taken into account,
synckithas better performance, TypeScript and native PnP support, etc.For benchmark, see un-ts/synckit#benchmark
Sometimes even better: un-ts/synckit/actions/runs/14015583415/job/39240872165#step:7:1
[email protected] did have some places can improve communication between threads, but only the communication part, and it's done in v0.4. I don't want to argue with the performance problem here. If maintainers have questions, please take a look at https://github.com/fisker/make-synchronized-benchmark or test yourself.
I don't see a problem with TypeScript and native PnP support here.
I don't see a problem with TypeScript and native PnP support here.
I found it could be that all jest test cases are run after building, so no .ts worker will be imported at that moment. For P'n'P, I don't know whether there is an e2e case for verifying.
What's the status of this PR?
I don't have time.to continue, i'll just close.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.