jest icon indicating copy to clipboard operation
jest copied to clipboard

[Feature]: Upgrade jest-environment-jsdom dependency to jsdom@^25.0.1

Open ThomasGreenspan opened this issue 5 months ago • 5 comments

🚀 Feature Proposal

For package jest-environment-jsdom, change dependency on jsdom from: "jsdom": "^22.0.0" to "jsdom": "^25.0.1"

Motivation

jsdom versions before 25.0.1 (including 25.0.0) indirectly rely on punycode which is deprecated and emits deprecation warnings for every test.

A more detailed explanation can be found on this older issue which was closed without addressing (although I believe it needs to be ugpraded all the way up to v25): https://github.com/jestjs/jest/issues/15148

Example

No response

Pitch

The package already relies on jsdom, this is just requesting an upgrade of one of its dependencies.

I currently use a dependency override and the behavior is fully preserved. Of course, I have a limited set of tests so I'm not sure that there is no impact but it is possible that this is a very small effortless change. While the override does handle my issue, overrides are always a little dangerous and I think it would be good for the lib to not rely on deprecated code.

ThomasGreenspan avatar Sep 27 '24 18:09 ThomasGreenspan