jest
jest copied to clipboard
jestjs
fix: correctly copy getters in `deepCyclicCopy`
Summary
Fixes #15196
deepCyclicCopyReplaceable just accesses the value unconditionally, but we have tests in deepCyclicCopy that getters are not accessed.
https://github.com/jestjs/jest/blob/91e80829a08b03ed7c0166e59543cd2a6b20d08b/packages/jest-matcher-utils/src/deepCyclicCopyReplaceable.ts#L104-L109
Not sure if this is the correct approach, but seems fine? Let's see what CI says
Test plan
Unit test added
Deploy Preview for jestjs ready!
| Name | Link |
|---|---|
| Latest commit | 2ecfd4eefe65303bf6275ac04a03de28db96d719 |
| Latest deploy log | https://app.netlify.com/sites/jestjs/deploys/66c44bacf6a7490008b7f99c |
| Deploy Preview | https://deploy-preview-15265--jestjs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.