jest icon indicating copy to clipboard operation
jest copied to clipboard

chore!: drop support for Node.js 21

Open mrazauskas opened this issue 1 year ago • 2 comments

Summary

Perhaps it is time to drop Node.js 21? It is end-of-life since 2024-06-01. Reference: https://github.com/nodejs/Release

Test plan

Green CI.

mrazauskas avatar Jun 10 '24 10:06 mrazauskas

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
Latest commit 4a247ef497a6c7b62938638ae462faf779924e14
Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6667f32139e1c40008269226
Deploy Preview https://deploy-preview-15118--jestjs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 10 '24 10:06 netlify[bot]

@SimenB Could you take a look, please? GHA is waiting for status checks on Node v21.x, because these are marked as required. Not so easy to remove them (;

mrazauskas avatar Jun 10 '24 12:06 mrazauskas

Not sure about this. It would mean people supporting >=20 wouldn't be able to use Jest. Same technically applies to >=18 already as we've dropped 19, so maybe not a big deal? And as long as we do support 18 (and 16 for that matter), the likelihood of those breaking are low.

So yeah, I think I convinved myself 😀

SimenB avatar Jul 12 '24 08:07 SimenB

I think that is fine, since Node.js does not recommend the odd versions for production anyways. Play with it, have fun, but that is it.

mrazauskas avatar Jul 12 '24 08:07 mrazauskas

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

github-actions[bot] avatar Aug 12 '24 00:08 github-actions[bot]