jest icon indicating copy to clipboard operation
jest copied to clipboard

[Chore]: Deprecated `abab` and `domexception` warnings in dependencies

Open dawidurbanski opened this issue 1 year ago • 1 comments

Version

29.7.0

Steps to reproduce

Run npm install jest-environment-jsdom

Expected behavior

Installs without warnings

Actual behavior

Warnings are raised.

npm WARN deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
npm WARN deprecated [email protected]: Use your platform's native DOMException instead

Additional context

Both abab and domexception packages are used by one of the dependencies: jsdom.

├─┬ jest-environment-jsdom 29.7.0
│ └─┬ jsdom 20.0.3
│   ├── abab 2.0.6
│   └─┬ data-urls 3.0.2
│     └── abab 2.0.6
└─┬ jest-environment-jsdom 29.7.0
  └─┬ jsdom 20.0.3
    └── domexception 4.0.0

Fortunately jsdom package removed both abab and domexception in version 23.0.0.

They also bumped data-urls version to 5.0, which also ditched the abab package.

So from 23.0.0 jsdom package is free of both of these packages.

I'm not exactly sure what implications would bumping [email protected] to 23.0.0 have, but it's fixed upstream so it's worth to see if this is relatively painless transition.

Pull request link.

Environment

System:
    OS: macOS 14.1.1
    CPU: (10) arm64 Apple M1 Pro
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.16.0/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    pnpm: 8.6.12 - ~/Library/pnpm/pnpm

dawidurbanski avatar Feb 10 '24 04:02 dawidurbanski

See https://github.com/jestjs/jest/pull/14846#issuecomment-1885785901

I should probably make a release so @jest/environment-jsdom-abstract exists on npm and the assumption it can be used is validated

SimenB avatar Feb 12 '24 10:02 SimenB

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Mar 13 '24 11:03 github-actions[bot]

A release has been made, and the diff in https://github.com/jestjs/jest/issues/14954#issuecomment-1988729969 shows how it can be used to use jsdom@24

SimenB avatar Mar 13 '24 12:03 SimenB

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

github-actions[bot] avatar Apr 13 '24 00:04 github-actions[bot]