jest icon indicating copy to clipboard operation
jest copied to clipboard

Stop issue from #444 causing randomly failing runs

Open lukeapage opened this issue 2 years ago • 7 comments

This is a recreation of my original PR: https://github.com/jestjs/jest/pull/11104

(sorry - it was ignored for a year, then got 2 review comments and then ignored for another year. I've tried mentioning, requesting review and asking for help on the forum). I'm hoping I can get some traction on this now, since our work-around, where we (and many other users) patch jest with every install is getting more difficult in jest v30 with the bundling.

Summary

We would like to not have jest failing multiple runs a day because of https://github.com/jestjs/jest/issues/4444.

See https://github.com/jestjs/jest/issues/4444#issuecomment-782923561 for an explanation of what is going on.

essentially "reasonably sure" in the comment means 99% of the time, but not 100% of the time, meaning jest fails some of the time, which is not great.

Test plan

This is really hard to test... If you think this is an approach you could accept I'd be happy to discuss what else you need.

I don't mind removing the console.log if you like or making this opt-in e.g. "makeJestWorkForLargeCodebasesOnWindows" or whatever you want me to do,, please tell me, I just want to stop having to patch jest and be allowed to update to v30.

lukeapage avatar Nov 07 '23 15:11 lukeapage

Deploy Preview for jestjs failed.

Built without sensitive environment variables

Name Link
Latest commit 575bc01309e312e9a8b2690ef846c03fbf0cdc61
Latest deploy log https://app.netlify.com/sites/jestjs/deploys/654a533040a9110008fcdef1

netlify[bot] avatar Nov 07 '23 15:11 netlify[bot]

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Feb 05 '24 16:02 github-actions[bot]

Yep, praying for some review or feedback…

lukeapage avatar Feb 05 '24 17:02 lukeapage

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar May 05 '24 18:05 github-actions[bot]

Please review or give some feedback - this is not stale, this blocks us from upgrading because we cannot patch jest any more.

lukeapage avatar May 05 '24 18:05 lukeapage

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Aug 03 '24 20:08 github-actions[bot]

Still awaiting review

lukeapage avatar Aug 04 '24 03:08 lukeapage