jestjs
Don't perform V8 instrumenting if !collectCoverage
If coverageProvider: "v8" is provided in the Jest config, then the overhead of V8 instrumenting occurs, even if collectCoverage: false.
This saves about ~100ms of Jest-invocation-time on my machine.
Hi @mitchhentgesspotify!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Currently checking some boxes with my company so that I can get that CLA signed, I'm on it chief :sunglasses:
Pong :pensive: I'm making progress, but I'm still "standing by" for the moment. I haven't dropped this, I promise :)
from our side you are in the clear, and they should be able to find your name in their inbox if they need to
Sounds like the (existing) Spotify CLA with Facebook should now be updated to include my GitHub details. I'll resolve the merge conflict, and hopefully the "CLA Check" action will be happy now :+1:
Missing Contributor License Agreement!
I'm guessing that it takes a bit for updates to [email protected] to propagate :thinking:
Hopefully the bot picks it up yeah. It sometimes needs a kick, but a rebase or comment usually helps, so let's see
I've emailed [email protected] early yesterday to get their perspective. I'll keep this thread updated when I get a response.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}