jest icon indicating copy to clipboard operation
jest copied to clipboard

[Bug]: Outdated webpack example in the docs

Open Mikilll94 opened this issue 2 years ago • 10 comments

Version

docs

Steps to reproduce

This page in the docs about Webpack is completely outdated: https://jestjs.io/docs/webpack

The syntax for loaders looks really strange and it probably originates from Webpack 2 or 3 (?) . In Webpack 4+ the syntax is completely different.

Additionally in Webpack 5 (which is present for about 1.5 year), the file-loader and url-loader are deprecated and should not be used. Instead the asset modules should be used.

Expected behavior

This page in the docs about Webpack should be up to date with Webpack 5 https://jestjs.io/docs/webpack

Actual behavior

This page in the docs about Webpack is completely outdated: https://jestjs.io/docs/webpack

Additional context

No response

Environment

Does not apply. This is the bug about Jest docs.

Mikilll94 avatar Mar 07 '22 21:03 Mikilll94

@Mikilll94 i would like to take this one

Biki-das avatar Mar 08 '22 05:03 Biki-das

@Biki-das Feel free to do it 😃

Mikilll94 avatar Mar 08 '22 19:03 Mikilll94

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Apr 07 '22 19:04 github-actions[bot]

PR very much welcome! 🙂

SimenB avatar Apr 08 '22 09:04 SimenB

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar May 08 '22 09:05 github-actions[bot]

Leaving my PR as a draft as I don't currently have the bandwidth to test the proposed change.

abdih avatar May 08 '22 09:05 abdih

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Jun 07 '22 10:06 github-actions[bot]

@abdih Can I be of any help on this ? Just looking for contributing

andrmaz avatar Jun 10 '22 06:06 andrmaz

@abdih Can I be of any help on this ? Just looking for contributing

Thanks for demonstrating your interest to contribute!

If you could test the changes (e.g., create a project that uses Webpack 4+ and validates the changes I've proposed to the Webpack.md), that would help.

We may very well find out that during some form of testing that either my changes are incomplete or have something incorrect.

abdih avatar Jul 10 '22 20:07 abdih

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Aug 09 '22 20:08 github-actions[bot]

@abdih Same here looking for a chance to contribute. Maybe this project could be an inspiration. I use webpack v5 and jest in it. https://github.com/NetworkRock/personalWebsite

NetworkRock avatar Aug 27 '22 16:08 NetworkRock

There is https://github.com/facebook/jest/pull/12823 with some unaddressed feedback - would love for somebody to pick it up and land it 🙂

SimenB avatar Aug 27 '22 17:08 SimenB

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Sep 26 '22 17:09 github-actions[bot]

@SimenB Can I contribute to this by resolving the issue?

BishtAman avatar Oct 03 '22 16:10 BishtAman

Sure. It would be great to improve the docs.

mrazauskas avatar Oct 04 '22 11:10 mrazauskas

Yeah, go for it!

SimenB avatar Oct 04 '22 18:10 SimenB

That would be great!

Ajay-singh1 avatar Oct 20 '22 01:10 Ajay-singh1

@BishtAman It seems 29 days have passed since I declared my contribution. Is there any opportunity for me to contribute? If I do not hear back from you, I will start working on it tomorrow. I should be able to create a PR within a few days.

ibuibu avatar Nov 02 '22 06:11 ibuibu

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

github-actions[bot] avatar Dec 08 '22 00:12 github-actions[bot]