Jesse Suen

Results 124 comments of Jesse Suen

> Rollout has revisionHistoryLimit: 2, but there are four replicaset in kubernetes. Expecting 3 replicaSet. FYI. The one should be deleted does not have ownerRef field. I think this only...

Some concerns which were discussed offline: 1. v1alpha1 weight is IntOrString whereas v1alpha2 and above is Int. Not sure which what our code uses. 2. Linkerd installs v1alpha2 TrafficSplit at...

@MarkSRobinson can you paste the PDB? With Rollouts, since this is not a built-in application controllers (Deployment, ReplicationController, ReplicaSet, and StatefulSet) you can only use `spec.minAvailable` and the value must...

To fix this, I think the existing `RolloutComplete()` helper should be renamed to `RolloutHealthy()` and we should introduce a new `RolloutComplete()` helper that ignores pod availability and only considers stable/current...

> I'm interested in this feature, too 👍 > Would this be in line with the direction maintainers want to go? > If so, I'm eager to contribute anything I...

Thank you for the detailed answers. Things are much clearer now. I now understand how it's possible to limit DeamonSets by labeling nodes. > I'm not sure if the user...

Thanks for the second use-case, I'll expand the scope of this to include the canary strategy.

While I think the spec you are proposing is ideal, I do want to call out some complications with the implementation. There is quite a bit of the blue-green code...

> Aha, I figured it out - the module in proxy.golang.org works fine but the contents behind the proxy - ie if you do GOPROXY=direct - do not match up....

Ohh I think you may be right about this. The release process is such that the tag comes first, and then the build. This sometimes leads to situation where even...