card
card copied to clipboard
jessepollak
Font in Card Type Logo
Looks like the text for the card company -- Mastercard, Visa, Discover, etc. -- is showing in Times New Roman in the demo on my computer.
+1. Font face is coming across incorrectly. Also are there any updates to the logos available? The visa one isn't their current logo.
Can you send a screenshot or some more information about the font face? Thanks!
@jessepollak
Tested on Chrome in https://jessepollak.github.io/card/
latest commit doesn't fix it for me. But even if the fix is a matter of applying an Arial font I imagine the Visa logo never used Arial, so it won't be accurate.
In fact, the Visa logo changed in 2005 and doesn't use these horizontal bars anymore. It now looks like this:
Can we get this updated? (sorry I don't have the technical ability to help with this).
@nickcom @jessepollak Isn't possible to use the actual logos instead reproducing it in CSS? Those companies provide their logo in a SVG format now. But it may causes copyright / trademark issues nah? Not an expert about this field.
What do you think ?
sure, that is one solution and probably the route I'll end up taking. But perhaps a more usable solution for everyone would be to somehow update this amazing plugin with the SVG icons that can be easily swapped around as they are updated over time? Just a suggestion (but one I don't know enough about to update the plugin myself I'm afraid).
@fulldecent We can use some SVG logos that WooCommerce has in its repository:
https://github.com/woocommerce/woocommerce/tree/master/assets/images/icons/credit-cards
