jessek
initial github actions implementation
Hi @jessek — I appreciate you approving it, but it doesn't work yet! Let me get it working first.
Ah. I see why it doesn't work. It has all of the "please generate a fatal error on any warning" throughout.
How do you want to handle this? Should we actually fix all the code? Or simple disable the warnings?
I think it's ok to turn off "treat warnings as errors". This code is so old we'd spend a lot of time trying to update it just to avoid compiler warnings.
FWIW, I tried to compile it today and got warnings from bootstrap.sh and then configure failed. Let's get it working again and then we can clean it up.
That seems like a good plan. We’ve been going through something similar on the sleuth kit side.
On Mon, Dec 2, 2024 at 3:34 PM Jesse Kornblum @.***> wrote:
I think it's ok to turn off "treat warnings as errors". This code is so old we'd spend a lot of time trying to update it just to avoid compiler warnings.
FWIW, I tried to compile it today and got warnings from bootstrap.sh and then configure failed. Let's get it working again and then we can clean it up.
— Reply to this email directly, view it on GitHub https://github.com/jessek/hashdeep/pull/419#issuecomment-2512758435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMFHLGI6YQW6377OOU5RGT2DS75FAVCNFSM6AAAAABS2GYX62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJSG42TQNBTGU . You are receiving this because you authored the thread.Message ID: @.***>