hashdeep icon indicating copy to clipboard operation
hashdeep copied to clipboard

hash.cpp:282: bad if test ?

Open dcb314 opened this issue 10 years ago • 2 comments

hash.cpp:282:20: warning: ordered comparison of pointer with integer zero [-Wextra]

    if(fdht->base>0){

Maybe better code

    if (fdht->base != MAP_FAILED) {

dcb314 avatar Oct 02 '15 15:10 dcb314

Yes, that would be better. Please submit a pull request.

simsong avatar Oct 03 '15 01:10 simsong

Please submit a pull request.

Sorry, no can do. I am happy for someone else to do one.

dcb314 avatar Oct 03 '15 07:10 dcb314