Jesse Hu comments

Results 76 comments of


                                            Jesse Hu

Fix issue when checking guest IP of the VM with Docker installed

Thanks @jjlimepoint. Your case "172.18.x.x" makes sense. "add something to bootstrap options as a IP filter list" is a good solution. I will update it later.

Fix issue when checking guest IP of the VM with Docker installed

Hi @jjlimepoint , I have updated the patch to use bootstrap options for the IP filter. Please take a look.

Can patchHelper provide an option to verify resourceVersion?

hi @fabriziopandini could we add the option MergeFromWithOptimisticLock to CAPI patch helper?

Can patchHelper provide an option to verify resourceVersion?

https://github.com/kubernetes-sigs/cluster-api/issues/8706 is exactly we meant. We hit bugs in the described scenario when using CAPI patchHelper.

:bug: Do not update KCP and MS status when unable to get workload cluster

/area machineset

:bug: Do not update KCP and MS status when unable to get workload cluster

/retest

:bug: Do not update KCP and MS status when unable to get workload cluster

@sbueringer Thanks very much for the summary. I totally agree on bullet 1/2/3. - To archive 1 (the ideal solution), it probably requires more work and more extensive change (as...

:bug: Do not update KCP and MS status when unable to get workload cluster

I observed the issue when upgrading CAPI components. Would it be able to produce the ClusterCacheTracker lock scenario when rolling update KCP controller deployment?

:bug: Do not update KCP and MS status when unable to get workload cluster

I'm sorry for the confusion that the forked repo was deleted by others today by mistake. I will create a new PR to handle the MS status update issue first...

🐛 Delete out of date machines with unhealthy control plane component conditions when rolling out KCP

LGTM! Waiting for CAPI team to take a look. Thanks!