New Features?

[uranyum238]

Hello, thank you for this project, very useful. I was just wondering if a new feature can be added. I need to write parentheses beside chords like C(2) Parentheses mean it is played 2 times or a tiny description beside chords like C#(or B#) but whenever I wrote down parentheses converting didn't work. I am not good at regular expressions :) Any ideas? Thanks...

[tomaszkalinowski]

Hi, Similar but not the same will be also useful for me:

1. possibility of putting comments in the chords line (might be on the end of the line, chords should be recognized in comments and transposed if necessary) F. ex.: D A //1st time play Hm, A
   sample text
2. possibility of marking optional chords (that do not have to be played) - by ,<> brackets or in different way F. ex.: D <A> //A is optional
   sample text

D A* //A is optional
sample text

Even without it - really great job!

[harshajayman]

Can somebody please take me through how to install this on a Wordpress site. Please... A wordpress plug-in would be even better

Many thanks

Harsha Jayamanne

On 6 Oct 2017, at 09:46, tomaszkalinowski [email protected] wrote:

Hi, Similar but not the same will be also useful for me:

possibility of putting comments in the chords line (might be on the end of the line, chords should be recognized in comments and transposed if necessary) F. ex.: D A //1st time play Hm, A sample text possibility of marking optional chords (that do not have to be played) - by ,<> brackets or in different way F. ex.: D //A is optional sample text D A* //A is optional sample text

Even without it - really great job!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[jessegavin]

@uranyum238 You wrote...

I need to write parentheses beside chords like C(2) Parentheses mean it is played 2 times

Why not just repeat the chord?

Example..

  G              D
Here is the first line
  C               C
Here is the second line

[jessegavin]

@uranyum238 and @tomaszkalinowski both asked about ways to insert "inline" comments on the lines with chords in them.

Using () might be a really good option. Also adding // at the end of a line might work too, even though it is very "programmer-y" :)

[jessegavin]

@harshajayman Thanks for your good idea of creating a Wordpress plugin. I'll consider that.

It's been a very long time since I have worked with Wordpress. If anyone here is interested in working on that, that would be really cool as well.

[uranyum238]

@harshajayman (Temporary Solution for WordPress) You can add js and css files in header.php by using this code <script src="https://cdn.rawgit.com/jessegavin/jQuery-Chord-Transposer/master/jquery.transposer.js"></script> <link rel="stylesheet" href="https://cdn.rawgit.com/jessegavin/jQuery-Chord-Transposer/master/jquery.transposer.css"> Then you need to add this code in footer.php somewhere before body HTML tag. $(function() { $("pre").transpose(); }); And finally your music notes have to be written between pre HTML tags. Like that, <pre data-key="C"> C G Am F When I find myself in times of trouble, Mother Mary comes to me C G F C/E Dm C Speaking words of wisdom, let it be </pre> And done.

[harshajayman]

Thanks a lot @uranyum238 I’ve been asking this question for a while and you are the only one to come through with some answer I’ll try this and let you know

Harsha Jayamanne

On 10 Oct 2017, at 15:50, uranyum238 [email protected] wrote:

@harshajayman (Temporary Solution for WordPress) You can add js and css files in header.php by using this code

Then you need to add this code in footer.php somewhere before body HTML tag. $(function() { $("pre").transpose(); }); And finally your music notes have to be written between pre HTML tags. Like that,

C G Am F
When I find myself in times of trouble, Mother Mary comes to me
C G F C/E Dm C
Speaking words of wisdom, let it be

And done.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[harshajayman]

It just doesn't work @uranyum238 and everybody. Doesn't show the transpose widget at all. When I checked the source all scripts are there. I have done the pre as advised. Just my luck! Anybody have any other ideas....please

[harshajayman]

@jessegavin You've done a great job with this and Ive seen it at work on some similar sites. As you are aware, lot of people like me are working on Wordpress now. This just doesn't work as it is now,in wordpress, I think due to Wordpress has its own jquery with different semantics. For example it doesn't like $. Please work on this and give me a plugin. I worship you like a god :)

[uranyum238]

@harshajayman It perfectly works on my friend's WordPress website. Even it works on mobile version which is worked with a plug in. I am not sure which error you get, but you can determine that error by using console. (ctr+shift+i for Chrome) or if you can share your page URL, I can check where the problem is, if it's possible.

[harshajayman]

Im jealous ! check this post http://www.sinhalasongbook.com/awurudu-panas-thunai/ http://www.sinhalasongbook.com/awurudu-panas-thunai/

I tried two different sites of mine in two different themes

This site is my main site and its running on genesis theme

as you would see I can see the scripts on the source file on browser

Have a look

Thanks a lot for your effort

Harsha

On 11 Oct 2017, at 19:58, uranyum238 [email protected] wrote:

@harshajayman https://github.com/harshajayman It perfectly works on my friend's WordPress website. Even it works on mobile version which is worked with plug in. I am not sure which error you get, but you can determine that error by using console. (ctr+shift+i for Chrome) or if you can share your page URL, I can check where the problem is, if it's possible.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jessegavin/jQuery-Chord-Transposer/issues/9#issuecomment-335913131, or mute the thread https://github.com/notifications/unsubscribe-auth/AVnoOzAi4x-JiMQlH2p8PxdIJPWiit31ks5srQ_dgaJpZM4PqBSQ.

[uranyum238]

@harshajayman If you send your email to me, I can write what I found. I think this section is not appropriate to discuss these kind of problems which are not related to the JS library.

[harshajayman]

Of course

[email protected]

Thanks

Harsha

On 11 Oct 2017, at 21:00, uranyum238 [email protected] wrote:

@harshajayman https://github.com/harshajayman If you send your email to me, I can write what I found. I think this section is not appropriate to discuss these kind of problems which are not related to the JS library.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jessegavin/jQuery-Chord-Transposer/issues/9#issuecomment-335930314, or mute the thread https://github.com/notifications/unsubscribe-auth/AVnoO-Sj9qNqFoP8RtCB-YU3Kubyqs0Sks5srR5IgaJpZM4PqBSQ.

[52344]

hey there ,, any one can help me to get this plugin ... I'm already add this script on my header.php but not work .. please help me

[zachrybaker]

Jesse, awesome work.

I have a use case that could really benefit from one additional feature, and that is attempting to "guess" the initial key should it not be known. I think there are plenty of folks out there who are not musically gifted enough (me included) to know the key a song is in reliably, consistently, by just looking at it.

From what I understand, It can be "guessed" by looking at "diatonic" scales. Specifically, if you take the most-used chords in a song, and look for the which key they are most diatonic against. Josh Frets explains it and even links to a spreadsheet that makes this pretty possible.

Anyway, I think it would be awesome if we could add that. I think it would work like this:

1. Create a list of the major/minor chords with their use count, by count descending. If more than five, then probably just the top five.
2. Find the key that has all those diatonic values (blue columns in his spreadsheet I believe).
3. Until a match is found, take the last chord off the list and try again...

[jessegavin]

@zachrybaker This is an AWESOME idea and something I'd like to implement. Thanks so much for your detailed explanation of the idea and for the link.

[jessegavin]

@tomaszkalinowski Thanks for the idea about comments. I've created a new separate issue for that.

[zachrybaker]

@jessegavin in the remote chance I get to this before you get around to it, do you take pull requests?

[jessegavin]

@zachrybaker I have taken pull requests and am very open to contributions

[kiyana76]

Hi, Similar but not the same will be also useful for me:

1. possibility of putting comments in the chords line (might be on the end of the line, chords should be recognized in comments and transposed if necessary) F. ex.: D A //1st time play Hm, A sample text
2. possibility of marking optional chords (that do not have to be played) - by ,<> brackets or in different way F. ex.: D //A is optional sample text

D A* //A is optional sample text

Even without it - really great job!

i use your example but chord line not recognized as chord line.do you have any idea why?