lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Add credential prompts for PKCS11-based SSH keys

Open Jadeiin opened this issue 6 months ago • 2 comments

  • PR Description Similar to #2239, add credential prompts for PKCS11-based SSH keys. OpenSSH code reference is here.
  • Please check if the PR fulfills these requirements
  • [x] Cheatsheets are up-to-date (run go generate ./...)
  • [x] Code has been formatted (see here)
  • [x] Tests have been added/updated (see here for the integration test guide)
  • [x] Text is internationalised (see here)
  • [x] If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • [x] Docs have been updated if necessary
  • [x] You've read through your own file changes for silly mistakes etc

Jadeiin avatar Jun 15 '25 19:06 Jadeiin

Similar to https://github.com/jesseduffield/lazygit/pull/4018

oliverpool avatar Jun 18 '25 14:06 oliverpool

Similar to #4018

I noticed that your PR was submitted a long time ago. Why hasn't it been merged yet?

Jadeiin avatar Jun 18 '25 14:06 Jadeiin

I noticed that your PR was submitted a long time ago. Why hasn't it been merged yet?

Because it fell through the cracks, apparently. Happens all the time when open source maintainers have little time next to their day jobs. I hope this will happen less often in the future, but do feel free to ping next time something seems to get stuck for no reason.

In this case I'd tend to merge this PR, and close #4018 as superseded by this. Does this work for both of you?

stefanhaller avatar Jun 19 '25 16:06 stefanhaller

I'm ok with it.

Jadeiin avatar Jun 19 '25 16:06 Jadeiin