lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Prepare remote url for specific branch

Open BElluu opened this issue 1 year ago • 2 comments

  • PR Description Before we always use "origin". Now I modified the operation to check the remote for a given branch, and based on the remote name, a remote URL is created. Fixed #3997

  • Please check if the PR fulfills these requirements

  • [x] Cheatsheets are up-to-date (run go generate ./...)
  • [x] Code has been formatted (see here)
  • [x] Tests have been added/updated (see here for the integration test guide)
  • [x] Text is internationalised (see here)
  • [x] If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • [x] Docs have been updated if necessary
  • [x] You've read through your own file changes for silly mistakes etc

BElluu avatar Nov 02 '24 16:11 BElluu

Hi @stefanhaller. What do you think about this changes?

BElluu avatar Nov 27 '25 08:11 BElluu

I'm sorry, I never got around to looking at this, and then it fell through the cracks. (You don't have to wait a whole year to ping me in a case like this 😉)

Meanwhile we have another PR that does a similar thing (#4775), and your branch has the same problem as that one. See my comments there. The difference is that the other PR always uses the checked-out branch, whereas yours always uses the selected local branch; both is wrong, you need to use one or the other case by case (or the selected remote if we press o on a commit of a remote branch).

But the bigger problem for me is the shift-O feature, which I don't really understand. Changing code that affects this feature without understanding what exactly it does is a problem; see https://github.com/jesseduffield/lazygit/pull/4775#issuecomment-3151285221.

stefanhaller avatar Nov 27 '25 18:11 stefanhaller