lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Add three theme options

Open oliviaBahr opened this issue 1 year ago • 2 comments

  • PR Description

    • Make title color options separate from border color options
    • Add option to change title color of selected tabs in inactive views

It's not a super important change I've just always personally thought keeping selected tabs in inactive views highlighted the same color (and just -= AttrBold) looks wrong. Normal image My preference is just bold image

When I added the change I noticed that changing the border color option also changed the title color and I thought that was unexpected behavior so I added the two other options. https://github.com/jesseduffield/lazygit/blob/6390b056785f6ea3e64acbe58eac163c18af1cbe/docs/Config.md?plain=1#L56-L62

  • Please check if the PR fulfills these requirements
  • [ ] Cheatsheets are up-to-date (run go generate ./...)
  • [ ] Code has been formatted (see here)
  • [ ] Tests have been added/updated (see here for the integration test guide)
  • [ ] Text is internationalised (see here)
  • [ ] Docs (specifically docs/Config.md) have been updated if necessary
  • [ ] You've read through your own file changes for silly mistakes etc

oliviaBahr avatar Apr 27 '24 00:04 oliviaBahr

I'll let @jesseduffield have a look at this, as I'm not personally interested in this change. Hope this doesn't sound offensive, I just need to cut down a bit on the number of things that I get involved in.

(Happy to help with getting the change into gocui though, if Jesse decides we want this.)

stefanhaller avatar Apr 27 '24 09:04 stefanhaller

I will get to this very soon!

jesseduffield avatar Apr 30 '24 01:04 jesseduffield