lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Redesign the `git log` half-screen view

Open mark2185 opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. Instead of just having the git log graph to the left and the diff to the right, I would also want to see a diff files panel.

Describe the solution you'd like The left panel could be split into an upper and lower half, where the upper one could show the git log graph, and the lower could show the diff files.

Describe alternatives you've considered None, actually.

Additional context Feast your eyes on this high quality prototype.

hq_render

mark2185 avatar Sep 02 '22 19:09 mark2185

Looks great! Man, it would be nice if we could resize the panels.

kadaan avatar Sep 03 '22 04:09 kadaan

Statically? Shouldn't be a problem, we already have that for the width of the left column, I think.

Dynamically? Well, uhh... it sure would be nice

mark2185 avatar Sep 03 '22 06:09 mark2185

hi @mark2185, I'd like to give this one a try. Please let me know if this is still needed. Thanks!

skolj avatar Feb 26 '24 21:02 skolj

It is still needed!

I'm just not sure how would we exactly switch to the lower panel (Diff panel) since we use h/l to switch to other panels so for this half-screen view we'd have to inject a diff panel between panels 4 and 5. Or let Enter on a commit would focus the Diff panel.

@stefanhaller @jesseduffield ideas? I'm worried about remapping Enter only in half-zoom view.

mark2185 avatar Feb 27 '24 07:02 mark2185

I could try injecting another panel if we're in this view unless we have other ideas..

skolj avatar Feb 29 '24 00:02 skolj