Branch renaming does not auto-apply dashes when renaming a newly created branch

[bassepeder]

Describe the bug When creating a new branch with spaces in the name, lazygit automatically applies dashes for the whitespaces. When renaming a newly creating branch with whitespaces in it, lazygit says that the branch name is not supported.

To Reproduce

• Create a new branch with whitespaces in its name.
• Rename the newly created branch with whitespaces in its name.

Expected behavior Lazygit adds dashes where whitespace is present.

Screenshots If applicable, add screenshots to help explain your problem.

Version info: Newest lazygit version

[mark2185]

Would you be interested in taking a shot at this?

I take it we just need to replace ' ' with '-' here.

[bassepeder]

Sure, here is a video of the problem:

https://user-images.githubusercontent.com/58905488/184503238-7d039c0a-6063-4208-92b4-62341b50b03e.mp4

[mark2185]

Oh, I meant "taking a shot" in the sense of "would you like to try and fix this"?

[bassepeder]

Oh sorry, my bad 😆 Yeah, I can give it a shot tomorrow 👍🏼

[bassepeder]

Sorry for the inactivity. Kinda forgot about this issue. @mark2185 Is this issue still relevant?

[mark2185]

Nobody fixed it in the meantime, as far as I'm aware :)

[mark2185]

Uhhh... I meant that it is still not fixed, so it should remain open :sweat_smile:

[mark2185]

Closed by #2990 .