lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Published 20 hours ago • verified publisher icon jesseduffield

Update Icon Support

Open joshmedeski opened this issue 2 years ago • 3 comments

Closes https://github.com/jesseduffield/lazygit/issues/1933

I'm adding additional Nerd font icon support:

  • Files status
  • Git status

Preview: Screen Shot 2022-05-09 at 2 50 49 PM

joshmedeski avatar May 09 '22 19:05 joshmedeski

Great idea! ~~Have you considered emoji support for gitmoji also?~~ Looks like emoji support for git names already exists under

git:
  parseEmoji: true

https://github.com/jesseduffield/lazygit/blob/master/docs/Config.md#default

danielebra avatar Jun 15 '22 04:06 danielebra

I've improved the code, added some more features, and have decent fallbacks.

@jesseduffield can you (or anyone else) do some testing and let me know if anything else needs to be done?

joshmedeski avatar Jul 27 '22 16:07 joshmedeski

Thanks for all the feedback. It looks like some of my opinionated changes should be reverted for now and individually introduced in separate PRs. I have a thought for how to do it more gracefully.

I'll make some updates in the next week and flag you for code review again.

joshmedeski avatar Aug 03 '22 16:08 joshmedeski

I'm going to close this for now. It seems like some of my breaking changes shouldn't all happen in one big PR, plus some of the icons I chose aren't preferred by the reviewers.

I'll keep maintaining my branch and I can change it into smaller PRs for more bite-sized changes.

joshmedeski avatar Sep 19 '22 19:09 joshmedeski

Hey, I'm ready to revisit this work and get some of the changes merged. What's the status of the big refactor? I'm happy to add full Nerd Font support.

joshmedeski avatar May 21 '23 02:05 joshmedeski