lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Range highlighting with custom colour specification doesn't seem to work

Open peppy opened this issue 3 years ago • 3 comments

With custom colour:

gui:
  # stuff relating to the UI
  scrollHeight: 4 # how many lines you scroll by
  scrollPastBottom: false # enable scrolling past the bottom
  commitLength:
    show: true
  mouseEvents: true
  skipUnstageLineWarning: true
  showFileTree: true
  showCommandLog: false
  showBottomLine: false
  theme:
    selectedLineBgColor:
      - '#413660'
    selectedRangeBgColor:
      - '#413660'

iTerm2 2022-04-19 at 02 40 33

With default colour:

gui:
  # stuff relating to the UI
  scrollHeight: 4 # how many lines you scroll by
  scrollPastBottom: false # enable scrolling past the bottom
  commitLength:
    show: true
  mouseEvents: true
  skipUnstageLineWarning: true
  showFileTree: true
  showCommandLog: false
  showBottomLine: false
  theme:
    selectedLineBgColor:
      - '#413660'
    # selectedRangeBgColor:
    #   - '#413660'

iTerm2 2022-04-19 at 02 41 41

Note that with a custom specification, the selected line seems to work, but range does not.

Tested on latest master (8b103b16bd3a06d0e661e507832459fae7ec1198).

(Also I don't think the config reload behaviour is working. I seem to still need to restart lazygit for config changes to stick)

peppy avatar Apr 19 '22 02:04 peppy

For selectedRangeBgColor, using color name green works fine, but hex #00ff00 doesn't work.

❯ lazygit --version                     
commit=, build date=, build source=homebrew, version=0.37.0, os=darwin, arch=arm64, git version=2.40.0

zhengpd avatar Mar 24 '23 12:03 zhengpd

This should be fixed on master, see #2483.

stefanhaller avatar Mar 24 '23 12:03 stefanhaller

This should be fixed on master, see #2483.

Good work 👍 . Just waiting for the new release.

zhengpd avatar Mar 24 '23 12:03 zhengpd