lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Can I have a full screen mode to view diff?

Open xaljer opened this issue 4 years ago • 15 comments
trafficstars

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

xaljer avatar Dec 13 '20 16:12 xaljer

if you go shift++ couple times after pressing enter on a file it should go full screen. Does that satisfy your use case?

jesseduffield avatar Dec 13 '20 20:12 jesseduffield

@jesseduffield I didn't get the full screen effect follow your description~

xaljer avatar Dec 16 '20 16:12 xaljer

Yup, it never lets you focus on "diff" window, so you can't make it go fullscreen. Would be cool if we had that.

dakyskye avatar Feb 25 '21 18:02 dakyskye

pressing enter on a file takes you to the diff window. Admittedly there isn't a generic way to focus the main window though

jesseduffield avatar Apr 06 '21 14:04 jesseduffield

Yes, the ability to focus on the diff window and making it larger would be very helpful indeed!!

AbeerVaishnav13 avatar Nov 03 '22 14:11 AbeerVaishnav13

I'm using this in my lazygit config file as a workaround, which makes ctrl-f show the selected commit in a subprocess, then press ENTER to exit back to lazygit.

customCommands:
  - key: '<c-f>'  # Ctrl-f (think "full screen") to show selected commit
    context: 'commits'
    command: "git show {{.SelectedLocalCommit.Sha}}"
    subprocess: true
    description: "Show selected commit"
    stream: true

mbhutton avatar Jan 07 '24 00:01 mbhutton

Is this somehow possible now?

nikbrunner avatar Jan 23 '24 11:01 nikbrunner

when using difft, I found that if we focus the patch window, the diff tool fallback to default diff. the keymap does no help to keep difft too. https://github.com/jesseduffield/lazygit/issues/1113#issuecomment-1879886174

konosubakonoakua avatar Jan 25 '24 03:01 konosubakonoakua

when using difft, I found that if we focus the patch window, the diff tool fallback to default diff. the keymap does no help to keep difft too. #1113 (comment)

Thank you this is helpful! I scoped it to files though, because what I would really like to achieve is to have the diff in full view and step through the diff and be able to stage hunks. But this is an improvement. :) I hope this there will be a possibility for this in the future.

nikbrunner avatar Jan 25 '24 08:01 nikbrunner

This issue should get high votes

wenjoy avatar Aug 14 '24 03:08 wenjoy

pressing enter on a file takes you to the diff window. Admittedly there isn't a generic way to focus the main window though

This is not enough if you want to scroll through full diff of a commit which is useful if you want to quickly glance over commit diff.

This git show behavior is currently possible in lazygit by manually specifying diff target, but this diff view cannot be made full screen.

Ideally it would be great if in full screen mode we could specify alternative pager which is useful for delta (and other diff tools probably) users where we could have single column layout for split-screen view and two column layout (delta --side-by-side) for full screen view.

jan-swiecki avatar Aug 17 '24 18:08 jan-swiecki