lazydocker icon indicating copy to clipboard operation
lazydocker copied to clipboard

Pressing the shortcut key should perform the associated action when the menu is open

Open ed-bassett opened this issue 6 years ago • 4 comments

Is your feature request related to a problem? Please describe. A good way to learn the available keyboard shortcuts in any given context is to open the menu and see what's available. It would be good if I didn't have to manually navigate the menu to perform an action.

Describe the solution you'd like I'd like the shortcut keys shown in a menu to perform the associated action

ed-bassett avatar Jul 02 '19 03:07 ed-bassett

I completely agree. @ed-bassett you truly have a strong grasp on good UX. If only we worked at the same company and I could regularly defer to your judgement about things like this.

I'll have a look into how straightforward something like this is (I suspect it's quite straightforward now that I've got a concept of a ParentView) and if so I might chuck a 'good first issue' label on this ticket. If you're in the mood for writing Go you might want to jump on this yourself ;)

jesseduffield avatar Jul 02 '19 06:07 jesseduffield

This is a really good idea, the current behaviour has tripped me up in both lazydocker and lazygit. In both cases (many months apart), I opened the menu by pressing x and couldn't figure out why the shortcuts shown in the menu didn't work.

(lazydocker and lazygit are both amazing, by the way. Thank you Jesse!)

rgwood avatar Apr 03 '20 04:04 rgwood

To me, the current behaviour is so surprising I'd consider it a bug.

adamal avatar Sep 26 '22 08:09 adamal

This has been implemented in lazygit (see here) but not lazydocker. Unfortunately lazydocker is behind on some refactorings but it should be fairly straightforward to go through each menu item and add a keybinding for the key here

jesseduffield avatar Oct 08 '22 19:10 jesseduffield