lazydocker icon indicating copy to clipboard operation
lazydocker copied to clipboard

Add shortcut (Ctrl+L) to clear logs

Open sunny-Ne5 opened this issue 1 year ago • 7 comments

Fix #403

sunny-Ne5 avatar Jul 19 '23 11:07 sunny-Ne5

Looking good. Two things:

  • Could we make this keybinding also available in the side views that render to the main view? I'd prefer to not have to hit enter in order to press ctrl+l
  • Looks like the keybinding isn't rendered properly in the keybindings menu (which you get upon pressing '?' image

Looks like we need to add a special key to the switch statement in GetKey() in pkg/gui/keybindings.go

jesseduffield avatar Jul 21 '23 08:07 jesseduffield

  • Could we make this keybinding also available in the side views that render to the main view? I'd prefer to not have to hit enter in order to press ctrl+l

Should we enable this keybinding for "Containers" or for other side views as well? For this I was planning to add one more entry to GetInitialKeybindings() in keybindings.go. Let me know if there is a better way to do it if it's repetitive.

*Looks like the keybinding isn't rendered properly in the keybindings menu (which you get upon pressing '?' Is this good? image

sunny-Ne5 avatar Jul 21 '23 12:07 sunny-Ne5

@sunny-Ne5 Sorry for the late reply! You'll only need the keybinding for containers and services, so feel free to just add an extra two keybindings for that

jesseduffield avatar Oct 09 '23 05:10 jesseduffield

I want to take a look at this PR to move it forward. @sunny-Ne5, are you still interested in this PR, you don't mind ?

peauc avatar Jun 15 '24 22:06 peauc

please go ahead

On Sun, Jun 16, 2024 at 3:54 AM PÉAU Clément @.***> wrote:

I want to take a look at this PR to move it forward. @sunny-Ne5 https://github.com/sunny-Ne5, are you still interested in this PR, you don't mind ?

— Reply to this email directly, view it on GitHub https://github.com/jesseduffield/lazydocker/pull/460#issuecomment-2170946237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7EORF3OVIQZZTORPOWGXLZHS5LPAVCNFSM6AAAAABJMA3TNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZQHE2DMMRTG4 . You are receiving this because you were mentioned.Message ID: @.***>

sunny-Ne5 avatar Jun 16 '24 06:06 sunny-Ne5

I've pulled your changed and have started a branch 👍. Thanks

peauc avatar Jun 16 '24 21:06 peauc

@jesseduffield requested changes have been made in my pull request 👍

peauc avatar Jun 16 '24 21:06 peauc