Jesse Hitch

Results 333 comments of Jesse Hitch

Please detail in the description of this PR what you're doing and why to make it easier to review. Ideally, please use the PR template.

It looks like there's an error after the nginx default config PR was merged. https://github.com/nextcloud/helm/actions/runs/7144375839/job/19639651937?pr=480#step:9:219

merged main and kicking off tests again, this time with new database tests :)

OK, now that I've finally spent some time looking at this, my first new request is that you rename the `.gotmpl` file extensions to be `.tpl` as that seems to...

I've tested this and it looks good to me :) Please still update the gotmpl file extensions to be `tpl` though, just for consistency.

@wrenix when you get a chance, could you please update the file extensions to `tpl` for the config files? Then we can get this merged :)

@provokateurin, since wrenix is a little busy right now, how about after the tests run (assuming they are all valid), we merge this, and then in #464, I can refactor...

> I think the file extensions should be fixed in this PR, but other than that it sounds good. Turns out since maintainers were given access to the PR, I...

Sorry for the delay! Looks like there's a conflict to resolve, but this otherwise seems like a fine change. The only thing I could think to imrpove it would be...

> @jessebot Sorry, I completely forgot about this PR. Me too 🤦 No problem at all! > The conflict is only with the version number. I think that's best fixed...